Repository navigation
Conversation
std.Build.addTranslateC is deprecated in Zig 0.17 and goes away in 0.18; the translate-c package (branch zig-0.17.x) is its replacement. Its struct fields are not default-initialised unless asked, so default_init keeps struct literals such as vtab.zig's sqlite3_module compiling against SQLite versions that add fields (xIntegrity in 3.44).
Owner
|
Good catch with the ci workflow! Thanks for your contribution! |
Greebling
self-requested a review
October 22, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small changes on top of this branch, to help vrischmann#215 land:
std.Build.addTranslateC, which is deprecated in 0.17 and slated for removal. It is pinned to the package'szig-0.17.xbranch. It needs.default_init = trueso struct literals keep zero defaults as with@cImport; without it, vtab.zig'ssqlite3_moduleliteral fails onxIntegrity(added in SQLite 3.44).Tested: the full test suite passes on Zig 0.17.0 (55/55) on macOS arm64 and aarch64 Linux, in-memory and file mode. It also compiles for x86_64/x86 musl, x86_64-windows and x86_64-macos.